Skip to content

[buildsystem] Improve solidity embeddability. #14860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 3, 2024

Conversation

aarlt
Copy link
Member

@aarlt aarlt commented Feb 15, 2024

No description provided.

@aarlt aarlt self-assigned this Feb 15, 2024
@aarlt aarlt force-pushed the improve_solidity_embeddability branch from a3ab335 to 094c9d4 Compare February 16, 2024 17:24
@aarlt aarlt marked this pull request as draft February 16, 2024 17:34
@aarlt aarlt force-pushed the improve_solidity_embeddability branch 3 times, most recently from 3aad121 to e5aed2f Compare February 16, 2024 18:44
@aarlt aarlt marked this pull request as ready for review February 16, 2024 18:45
@aarlt aarlt requested a review from cameel February 16, 2024 18:46
@aarlt aarlt changed the title Improve solidity embeddability. [buildsystem] Improve solidity embeddability. Feb 16, 2024
@aarlt
Copy link
Member Author

aarlt commented Feb 17, 2024

I just created a repository showing how solidity can be easily embedded: cmake_vcpkg_solidity.

Copy link

github-actions bot commented Mar 3, 2024

This pull request is stale because it has been open for 14 days with no activity.
It will be closed in 7 days unless the stale label is removed.

@github-actions github-actions bot added the stale The issue/PR was marked as stale because it has been open for too long. label Mar 3, 2024
@ekpyron ekpyron removed the stale The issue/PR was marked as stale because it has been open for too long. label Mar 6, 2024
Copy link

This pull request is stale because it has been open for 14 days with no activity.
It will be closed in 7 days unless the stale label is removed.

@github-actions github-actions bot added the stale The issue/PR was marked as stale because it has been open for too long. label Mar 21, 2024
@aarlt aarlt removed the stale The issue/PR was marked as stale because it has been open for too long. label Mar 26, 2024
@nikola-matic nikola-matic force-pushed the improve_solidity_embeddability branch from e5aed2f to 780018a Compare April 3, 2024 10:39
Copy link
Member

@r0qs r0qs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nikola-matic nikola-matic merged commit a26691e into develop Apr 3, 2024
@nikola-matic nikola-matic deleted the improve_solidity_embeddability branch April 3, 2024 11:21
@r0qs
Copy link
Member

r0qs commented Apr 3, 2024

I just created a repository showing how solidity can be easily embedded: cmake_vcpkg_solidity.

I approved, although I couldn't test using your example:

Call Stack (most recent call first):
  scripts/cmake/vcpkg_download_distfile.cmake:270 (z_vcpkg_download_distfile_show_proxy_and_fail)
  scripts/cmake/vcpkg_from_github.cmake:106 (vcpkg_download_distfile)
  ports/liblzma/portfile.cmake:1 (vcpkg_from_github)
  scripts/ports.cmake:170 (include)


error: building liblzma:x64-linux failed with: BUILD_FAILED
Elapsed time to handle liblzma:x64-linux: 500 ms
Please ensure you're using the latest port files with `git pull` and `vcpkg update`.
Then check for known issues at:
  https://github.com/microsoft/vcpkg/issues?q=is%3Aissue+is%3Aopen+in%3Atitle+liblzma

The error seems to be related with the recent problems in liblzma: microsoft/vcpkg#37893 and https://tukaani.org/xz-backdoor/

@cameel
Copy link
Member

cameel commented Apr 4, 2024

I wonder why it tries to pull in liblzma in the first place. I hope none of our dependencies depends on it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants