-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update documentation about codehash
behaviour according to EIP-1052 and EIP-161
#14793
Conversation
Thank you for your contribution to the Solidity compiler! A team member will follow up shortly. If you haven't read our contributing guidelines and our review checklist before, please do it now, this makes the reviewing process and accepting your contribution smoother. If you have any questions or need our help, feel free to post them in the PR or talk to us directly on the #solidity-dev channel on Matrix. |
Please, see the following issue: #14794 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much @ustas-eth, I just have one comment ;)
codehash
behaviour according to EIP-1052 and EIP-161
Thanks @ustas-eth. Could you please just squash the commits and rebase with the |
@r0qs I did, but I'm not sure if the result is what you expected. I'm not very proficient with git :') |
… state Co-authored-by: r0qs <rodrigo.saramago@protonmail.com>
haha no problem, I fixed it for you ;) Thanks a lot for your contribution! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm kinda of approving myself here, so @cameel, please take a look when you have some time ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Approving this! :)
Fixes #14794 by adding a warning for the
codehash
usage.