Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Boost 1.65 is not compatible #15117

Closed
guidanoli opened this issue May 18, 2024 · 2 comments · Fixed by #15376
Closed

Boost 1.65 is not compatible #15117

guidanoli opened this issue May 18, 2024 · 2 comments · Fixed by #15376
Labels
bug 🐛 documentation 📖 low effort There is not much implementation work to be done. The task is very easy or tiny. low impact Changes are not very noticeable or potential benefits are limited. must have Something we consider an essential part of Solidity 1.0.

Comments

@guidanoli
Copy link

Page

Installing the Solidity Compiler — Solidity 0.8.24 documentation

Abstract

The page states that Solidity v0.8.24 can be compiled with Boost 1.65, however, I was not able to.
Apparently, it has something to do with the boost/container_hash library, which is imported here.
This module was only available in Boost 1.67, apparently.
See the changelog on Boost documentation.
@nikola-matic
Copy link
Collaborator

Yup, looks like we introduced boost/container_hash in 2022 and did not update the docs.

@guidanoli
Copy link
Author

Not assigning responsibilities or anything, but this would be caught if there were a CI that tried to build with the dependencies in the oldest supported version.

@cameel cameel mentioned this issue May 23, 2024
Open
@nikola-matic nikola-matic added low impact Changes are not very noticeable or potential benefits are limited. medium effort Default level of effort labels May 29, 2024
@github-actions github-actions bot added the stale The issue/PR was marked as stale because it has been open for too long. label Aug 28, 2024
@cameel cameel removed the stale The issue/PR was marked as stale because it has been open for too long. label Aug 29, 2024
@cameel cameel mentioned this issue Aug 30, 2024
Merged
@ethereum ethereum deleted a comment from github-actions bot Aug 30, 2024
@cameel cameel added low effort There is not much implementation work to be done. The task is very easy or tiny. bug 🐛 must have Something we consider an essential part of Solidity 1.0. and removed medium effort Default level of effort labels Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛 documentation 📖 low effort There is not much implementation work to be done. The task is very easy or tiny. low impact Changes are not very noticeable or potential benefits are limited. must have Something we consider an essential part of Solidity 1.0.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump min Boost dependency to 1.67 ethereum/solidity
3 participants
@cameel @nikola-matic @guidanoli