fix: ensure CLI replaces path separator on Windows platforms correctly #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x-r4bbit
added a commit
to 0x-r4bbit/vibranium
that referenced
this pull request
Jun 10, 2019
Due to differences between solc and solcjs in their generated output on Windows machines (ethereum/solc-js#365), compilation will always break because solcjs doesn't handle output paths correctly. A fix for this has been proposed here ethereum/solc-js#367, once that is merged, we can roll back to solcjs again.
0x-r4bbit
added a commit
to 0x-r4bbit/vibranium
that referenced
this pull request
Jun 10, 2019
Due to differences between solc and solcjs in their generated output on Windows machines (ethereum/solc-js#365), compilation will always break because solcjs doesn't handle output paths correctly. A fix for this has been proposed here ethereum/solc-js#367, once that is merged, we can roll back to solcjs again.
0x-r4bbit
added a commit
to 0x-r4bbit/vibranium
that referenced
this pull request
Jun 10, 2019
Due to differences between solc and solcjs in their generated output on Windows machines (ethereum/solc-js#365), compilation will always break because solcjs doesn't handle output paths correctly. A fix for this has been proposed here ethereum/solc-js#367, once that is merged, we can roll back to solcjs again.
chriseth
approved these changes
Jun 17, 2019
|
Thanks! |
|
Wonderful, thanks for merging this @chriseth ! Do you know when a release can be expected, that includes this fix? |
|
The releases are synchronized with Solidity's releases. We haven't set a release date yet, but should be in about 2 weeks. |
|
Hey @chriseth just wanted to check in, any updates on the release? :) |
|
@PascalPrecht we released on npm last week, it should contain this PR. |
0x-r4bbit
added a commit
to 0x-r4bbit/vibranium
that referenced
this pull request
Jul 1, 2019
Now that ethereum/solc-js#367 has landed in solcjs and published, we can roll back to using it again, making the CI setup significantly more trivial and faster. Closes #63
0x-r4bbit
added a commit
to 0x-r4bbit/vibranium
that referenced
this pull request
Jul 1, 2019
Now that ethereum/solc-js#367 has landed in solcjs and published, we can roll back to using it again, making the CI setup significantly more trivial and faster. Closes #63
|
Ah, thank you @chriseth ! 🙏 I didn't even check haha |
0x-r4bbit
added a commit
to 0x-r4bbit/vibranium
that referenced
this pull request
Jul 1, 2019
Now that ethereum/solc-js#367 has landed in solcjs and published, we can roll back to using it again, making the CI setup significantly more trivial and faster. Closes #63
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #365