Support linking via hash. #266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axic
reviewed
Oct 4, 2018
linker.js
Outdated
| @@ -1,3 +1,5 @@ | |||
| var sha3 = require('crypto-js/sha3'); | |||
There was a problem hiding this comment.
This should use ethereumjs-util, which is already in package.json.
There was a problem hiding this comment.
ethereumjs-util only is a dev dependency, but I think this here needs to be an actual dependency. I want to avoid pulling in all of ethereumjs-util into the dependencies.
There was a problem hiding this comment.
Then it should use keccak.js (or whatever ethereumjs-util is using). crypto-js/sha3 isn't the best library.
axic
reviewed
Oct 6, 2018
linker.js
Outdated
| }; | ||
|
|
||
| replace(libraryName); | ||
| replace(sha3(libraryName, {outputLength: 256}).toString()); |
axic
reviewed
Oct 6, 2018
test/linker.js
Outdated
| @@ -82,3 +82,19 @@ tape('Link references', function (t) { | |||
| st.end(); | |||
| }); | |||
| }); | |||
|
|
|||
| tape('Linker via hash', function (t) { | |||
| t.test('Non-hashed placeholder', function (st) { | |||
chriseth
force-pushed
the
linkViaHash
branch
2 times, most recently
from
a6768c8 to
e73312c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required by ethereum/solidity#5145