Compile pipeline: update types #5965
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for remixproject ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
yann300
force-pushed
the
fix_remappings
branch
3 times, most recently
from
65a5f5e to
3bf21e4
Compare
Aniket-Engg
force-pushed
the
fix_remappings
branch
from
3bf21e4 to
e103f7f
Compare
Aniket-Engg
reviewed
Apr 29, 2025
| async (url, cb) => { | ||
| // we first try to resolve the content from the compilation target using a more appropriate path | ||
| const path = `${targetPath}/${url}` | ||
| if (compilationTargets[path] && compilationTargets[path].content) { | ||
| console.log('resolving', targetPath, url) |
| return cb(null, compilationTargets[path].content) | ||
| } else { | ||
| await this.call('contentImport', 'resolveAndSave', url).then((result) => cb(null, result)).catch((error) => cb(error.message)) | ||
| cb('dependency not found ' + url) | ||
| // await this.call('contentImport', 'resolveAndSave', url).then((result) => cb(null, result)).catch((error) => cb(error.message)) |
There was a problem hiding this comment.
remove commented code
Aniket-Engg
approved these changes
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
compilefunction with more types.