Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add running scripts & FAS #2994

Merged
merged 3 commits into from
Nov 25, 2020
Merged

add running scripts & FAS #2994

merged 3 commits into from
Nov 25, 2020

Conversation

ryestew
Copy link
Collaborator

@ryestew ryestew commented Nov 6, 2020

@ryestew
Copy link
Collaborator Author

ryestew commented Nov 6, 2020

needs links to ethers & web3
fix the nav in index.rst
a few more scripts in FAS
link to the medium post about async await
settings doc needs an update.

@ryestew
Copy link
Collaborator Author

ryestew commented Nov 14, 2020

Still needs an update to the settings page (although this could go in another PR). Maybe needs more scripts in the FAS page.

@ryestew
Copy link
Collaborator Author

ryestew commented Nov 15, 2020

Settings update should go into another PR.

Copy link
Collaborator

@Aniket-Engg Aniket-Engg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is good to start with

1. Make sure the **Generate contract metadata** option is **checked** in the settings module.
[Settings documentation](settings.html) ( ROB TODO: and make sure to update Settings.md!!!)

2. **Async/await scripts do not currently work on the JSVM**
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will be fixed for the current release


4. Write the script

5. To run the script - either have the script be the active file in the editor and run `remix.exeCurrent()` in the console or right click on the script in the files explorer to get the popup context menu and select the **run** option. (ROB TODO - update with an image of the context menu)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's a TODO missing
(ROB TODO - update with an image of the context menu)

The example below is to deploy a solidity contract named CustomERC20.sol. That contract had been compiled and its metadata generated and put into the browser/artifacts folder. This example is using the web3.js library. Ethers.js could also be used.

```
(async () => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this also be in FAS.md

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is in there.

@yann300 yann300 merged commit 0badb73 into master Nov 25, 2020
@yann300 yann300 deleted the fasPlus branch November 25, 2020 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Frequenty Asked Scripts
3 participants