Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple highlight per plugin #2815

Merged
merged 7 commits into from
May 11, 2020
Merged

Allow multiple highlight per plugin #2815

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f465caf
allow multiple highlight per plugin
yann300 May 4, 2020
3373887
Added line class to hightlighter
ioedeveloper May 6, 2020
6b5dd74
Editor scroll
ioedeveloper May 7, 2020
bff67fd
Fixed linting error
ioedeveloper May 7, 2020
68e94cf
add more tests
yann300 May 11, 2020
4d12181
remove uneeded fn
yann300 May 11, 2020
c585030
remove uneeded commands
yann300 May 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
remove uneeded commands
  • Loading branch information
@yann300
yann300 committed May 11, 2020
commit c58503046a3cf49bf7e0a6afb8f6531bb48fd0d7
15 changes: 0 additions & 15 deletions test-browser/commands/elementIsNotPresent.js
View file
Open in desktop

This file was deleted.

15 changes: 0 additions & 15 deletions test-browser/commands/elementIsPresent.js
View file
Open in desktop

This file was deleted.

8 changes: 4 additions & 4 deletions test-browser/tests/editor.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ module.exports = {
.executeScript('remix.exeCurrent()')
.switchFile('browser/3_Ballot.sol')
.editorScroll('down', 60)
.elementIsNotPresent('.highlightLine32')
.waitForElementNotPresent('.highlightLine32')
.checkElementStyle('.highlightLine40', 'background-color', 'rgb(8, 108, 181)')
.checkElementStyle('.highlightLine50', 'background-color', 'rgb(8, 108, 181)')
},
Expand All @@ -102,9 +102,9 @@ module.exports = {
.executeScript('remix.exeCurrent()')
.switchFile('browser/3_Ballot.sol')
.editorScroll('down', 60)
.elementIsNotPresent('.highlightLine32')
.elementIsNotPresent('.highlightLine40')
.elementIsNotPresent('.highlightLine50')
.waitForElementNotPresent('.highlightLine32')
.waitForElementNotPresent('.highlightLine40')
.waitForElementNotPresent('.highlightLine50')
.end()
},

Expand Down