Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added missing reject #2551

Merged
merged 3 commits into from
Jan 23, 2020
Merged

added missing reject #2551

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e77bc02
added missing `reject`
yann300 Jan 22, 2020
4a1f0cc
fix typo
yann300 Jan 22, 2020
b0e778f
call `reject` after `console`
yann300 Jan 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix typo
  • Loading branch information
@yann300
yann300 authored Jan 22, 2020
commit 4a1f0cc40f73a2687d6fd1b3c106387e3f835bed
2 changes: 1 addition & 1 deletion src/app/files/compiler-metadata.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ class CompilerMetadata extends Plugin {
if (provider && path) {
self.executionContext.detectNetwork((err, { id, name } = {}) => {
if (err) {
reject(error)
reject(err)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think reject should be called after console

console.log(err)
} else {
var fileName = self._JSONFileName(path, contractName)
Expand Down