Multi param angles content #1307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yann300
reviewed
May 15, 2018
src/multiParamManager.js
Outdated
| @@ -2,6 +2,7 @@ | |||
|
|
|||
| var yo = require('yo-yo') | |||
| var css = require('./universal-dapp-styles') | |||
| // var helper = require('../remix/remix-lib/src/execution/txHelper') | |||
There was a problem hiding this comment.
we should perhaps remove the comment if this is not going to be readded in the future
yann300
reviewed
May 15, 2018
| } | ||
|
|
||
| makeMultiVal () { | ||
| var inputString = this.basicInputField.value |
There was a problem hiding this comment.
I think we might need to wrap with double quote here
params = params.replace(/(^|,\s+|,)(\d+)(\s+,|,|$)/g, '$1"$2"$3') // replace non quoted number by quoted number
params = params.replace(/(^|,\s+|,)(0[xX][0-9a-fA-F]+)(\s+,|,|$)/g, '$1"$2"$3') // replace non quoted hex string by quoted hex string
cause the JSON.parse will break if some values are not wrapped ...
yann300
reviewed
May 15, 2018
src/multiParamManager.js
Outdated
| var multiOnClick = () => { | ||
| var valArray = multiFields.querySelectorAll('input') | ||
| var valArray = this.multiFields.querySelectorAll('input') |
There was a problem hiding this comment.
perhaps we can use getMultiValsString here
ryestew
force-pushed
the
multi_param_angles_content
branch
from
5031c7e to
6e11efe
Compare
ryestew
force-pushed
the
multi_param_angles_content
branch
from
372784e to
156732d
Compare
ryestew
force-pushed
the
multi_param_angles_content
branch
from
156732d to
2d549dc
Compare
yann300
approved these changes
May 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatically wrap strings and numbers and 0x in double quotes from the multi inputs ( the expanded view) & copying over the content between the expanded and contracted views.