Use ethers for abi coding #1277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
yann300
commented
Apr 25, 2018
yann300
commented
- improve browser testing
- adapt return values to match ethers.js decoded value in browser test
yann300
force-pushed
the
useEthersForAbiCoding
branch
from
ac78d63 to
dea6cca
Compare
yann300
force-pushed
the
useEthersForAbiCoding
branch
from
cad456c to
85c724d
Compare
ninabreznik
reviewed
Apr 26, 2018
test-browser/helpers/contracts.js
Outdated
| @@ -108,6 +108,7 @@ function verifyCallReturnValue (browser, address, checks, done) { | |||
| } | |||
| return ret | |||
| }, [address], function (result) { | |||
| console.log(result) | |||
There was a problem hiding this comment.
Do you want to leave console.log in?
There was a problem hiding this comment.
no right better to remove it
ninabreznik
reviewed
Apr 26, 2018
| client.getText('#editor-container div[class^="terminal"] span[id="tx' + txHash + '"] table[class^="txTable"] #decodedoutput', (result) => { | ||
| console.log(result) | ||
| var equal = deepequal(JSON.parse(result.value), JSON.parse(expectedReturn)) | ||
| if (!equal) { |
ninabreznik
reviewed
Apr 26, 2018
| @@ -16,7 +16,7 @@ module.exports = { | |||
| .clickFunction('getFromLib - call') | |||
| .waitForElementPresent('div[class^="contractActionsContainer"] div[class^="value"] ul') | |||
| .perform((client, done) => { | |||
| contractHelper.verifyCallReturnValue(browser, '0x35ef07393b57464e93deb59175ff72e6499450cf', ['0: uint256: 1', '0: uint256: 3456', '0: address: 0x35ef07393b57464e93deb59175ff72e6499450cf'], () => { | |||
| contractHelper.verifyCallReturnValue(browser, '0x35ef07393b57464e93deb59175ff72e6499450cf', ['0: uint256: 1', '0: uint256: 3456', '0: address: 0x35eF07393b57464e93dEB59175fF72E6499450cF'], () => { | |||
There was a problem hiding this comment.
This part I don't quite understand - why are some letters capitalized?
There was a problem hiding this comment.
the old decoder would just return basic hex number, the new one take care of returning a valid checksum address
There was a problem hiding this comment.
the function is here : https://github.com/ethereumjs/ethereumjs-util/blob/master/docs/index.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.