Piper/fix block tests invalid state

[pipermerriam]

Fix the VM issues and some other bytes/str/int/long py2/3 related bugs.

[pipermerriam]

@vbuterin this PR fixes some python3 errors that have been introduced in some of your recent work implementing the various EIP proposals.

[konradkonrad]

why did you remove this?

[pipermerriam]

It is only used by the slogging module so I moved it over to there. Happy to move it back if it's a problem.

[konradkonrad]

This looks okay to me -- in general I think I prefer PR's that stay inside their scope, i.e. fixing py3 things should not try to refactor the package structure, too. (Not that I haven't broken that rule myself in the past ;) )

[pipermerriam]

I completely agree with keeping pull requests contained to single things. I
feel like this specific refactor was somehow related but I'm struggling to
recall how. Maybe relative imports?

Either way I'll do better keeping unrelated things separate

On Wed, Jun 29, 2016, 9:05 AM konradkonrad notifications@github.com wrote:

This looks okay to me -- in general I think I prefer PR's that stay inside
their scope, i.e. fixing py3 things should not try to refactor the package
structure, too. (Not that I haven't broken that rule myself in the past ;) )

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#369 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAyTgqaL_gVyCW8f2HcdejUTqGb5vLQSks5qQomvgaJpZM4I9VOU
.