Switches hash-to-field to new v06 hash system #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarlBeek
changed the title
hwwhww
reviewed
Apr 1, 2020
hwwhww
approved these changes
Apr 7, 2020
CarlBeek
commented
Apr 30, 2020
|
@CarlBeek I pushed the fix into this branch, all the tests pass now. |
|
Thanks for pushing the changes. I'll check my local flake8/mypy config. Good to merge! |
pipermerriam
reviewed
May 6, 2020
| raise ValueError('DST must be <= 255 bytes') | ||
| ell = math.ceil(len_in_bytes / b_in_bytes) | ||
| if ell > 255: | ||
| raise ValueError('invalid len in bytes for hash function') |
There was a problem hiding this comment.
It would be good to include both the value of ell and the limit value in this message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
The BLS hash-to-curve spec is being changed from v05 -> v06. BLS hash-to-curve It is basically a change from repeated HKDF calls to direct SHA256 calls. This has the advantage of halving the number of SHA256 calls (and allows for other improvements for other curves in the hash-to-curve suite). See here for the full discussion: cfrg/draft-irtf-cfrg-hash-to-curve#202
The changes made are summarised in PRs 212 (specs update), 214 (proof of concept implementation) & 217 (test vectors).
How was it fixed?
The new specs & tests were implemented.
Please do not merge. This PR is for visibility for now until V06 is officially released.
To do:
Cute Animal Picture