Deploy accept codes

[KolbyML]

Accept codes is a breaking change to the network #370

With this issue I want to gauge how teams want to deploy this change. There are 2 ways we can go about it

• 1. ship the breaking change around the same time like we did in the past
• 2. deploy the change using Protocol versioning and upgrading. #371

I want to gauge team interest in which approach we will take for this change. I think overall long term 2) is a fair solution, but it does add a lot of complexity to Portal Client implementations which currently doesn't exist so we wouldn't be able to ship it over night I would assume.

So maybe people can give there opinions then we can make a decision from there. In the future I expect all breaking changes to be shipped with 2, I would still consider 1 partially due to us not really having any adoption yet, and us not having built out the infrastructure out yet.

But thinking more about it, I think using 2) clients could implement Accept codes on their own time and not worry about coordinating this change, since clients who supported the update would use the update and clients that didn't wouldn't.

[ScottyPoi]

I think that it is worth delaying shipping accept codes so that we have a version upgrade to perform once we finalize the versioning idea.

[pipermerriam]

I will get #371 converted to a pull request before the end of the week so that client implementations of this can proceed.

[kdeme]

I would either go for option ii.: it's added work & complexity but a development we have to make eventually anyhow.

Or, if we do not want to add that extra dev work right now, I would go for iii., which is, just deploy it coordinated like we have been doing in the past. We are still in the stage where we can do this.

Basically choosing between time invested well or no time invested at all. Option i. seems to have neither.

[KolbyML]

@kdeme option 1) and 3) are the same option

[kdeme]

@kdeme option 1) and 3) are the same option

Oh, oops. I read that to quickly and assumed 1) was about doing the change at a specific timestamp/epoch. Sorry about that.

Well, in that case I don't mind either. 1) is definitely easier for now.

[fearlessfe]

I prefer the options ii , but the protocol are still in progress.
But if the accept codes change is urgent, perhaps option i is better, that the only way we can choose now