This repository was archived by the owner on Sep 5, 2020. It is now read-only.
Minor spelling/grammatical changes. #3083
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolovim
suggested changes
Oct 2, 2017
|
|
||
| *** | ||
|
|
||
| ### mist.menu.update(id, [, options] [, callback]) | ||
|
|
||
| Works like `mist.menu.add()`, but all but the `id` parameters are optional. | ||
| Works like `mist.menu.add()`, but all of the `id` parameters are optional. |
There was a problem hiding this comment.
You've changed the meaning of this sentence. All but the ID param is optional. Agree that the sentence is clunky, though. Feel free to give it another whirl or revert this change.
ericjarvies
commented
Oct 3, 2017
Merged
|
Thanks for the PR. I've moved your changes into a new PR, where I've added a small change. (#3118) |
|
This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.