Spectron testing suite

.eslintrc.yml

@@ -25,7 +25,8 @@ rules:
   import/no-extraneous-dependencies:  ## checks if required modules are missing in packages.json
     - error
     - devDependencies:  ## declares files, whose imports belong to devDependencies
-      - "**/scripts/*.js"
+      - "**/scripts/build-dist.js"
+      - "**/tests/_base.js"
       - "**/*.test.js"
 
 globals:  # don't warn about missing declarations

README.md

@@ -225,3 +225,11 @@ It expects installer/zip files to be in the generated folders e.g. `dist_mist/re
 ### Code signing for production
 
 **As of [#972](https://github.com/ethereum/mist/pull/972) we've updated the build process and thus need to redo code-signing.**
+
+
+## Testing
+
+First make sure to build Mist with:
+`gulp mist --platform [mac,linux]` or `gulp wallet --platform [mac,linux]`.
+
+Then run `gulp test-mist` or `gulp test-wallet`, accordingly.

gulpfile.js

@@ -250,7 +250,7 @@ gulp.task('build-dist', ['download-signatures', 'copy-i18n'], (cb) => {
             },
             dmg: {
                 background: '../build/dmg-background.jpg',
-                'icon-size': 128,
+                iconSize: 128,
                 contents: [{
                     x: 441,
                     y: 448,
@@ -322,11 +322,9 @@ gulp.task('release-dist', ['build-dist'], (done) => {
         if (platformIsActive(osArch)) {
             switch (osArch) {  // eslint-disable-line default-case
             case 'win-ia32':
-                // cp(path.join('win-ia32', `${applicationName} Setup ${version}-ia32.exe`), `${appNameHypen}-win32-${versionDashed}.exe`);
                 cp(`${applicationName}-${version}-ia32-win.zip`, `${appNameHypen}-win32-${versionDashed}.zip`);
                 break;
             case 'win-x64':
-                // cp(path.join('win', `${applicationName} Setup ${version}.exe`), `${appNameHypen}-win64-${versionDashed}.exe`);
                 cp(`${applicationName}-${version}-win.zip`, `${appNameHypen}-win64-${versionDashed}.zip`);
                 break;
             case 'mac-x64':
@@ -411,15 +409,22 @@ gulp.task('wallet-checksums', (cb) => {
 });
 
 
-gulp.task('test-wallet', () => {
+const testApp = (app) => {
     return gulp.src([
-        './tests/wallet/*.test.js',
-    ])
-    .pipe(mocha({
+        `./tests/${app}/*.test.js`,
+    ]).pipe(mocha({
         timeout: 60000,
         ui: 'exports',
         reporter: 'spec',
     }));
+};
+
+gulp.task('test-wallet', () => {
+    testApp('wallet');
+});
+
+gulp.task('test-mist', () => {
+    testApp('mist');
 });
 
 

interface/client/lib/signatures.js

@@ -10015,5 +10015,20 @@ window.SIGNATURES = {
     ],
     "0x38bbfa50": [
         "__callback(bytes32,string,bytes)"
+    ],
+    "0xbc08afd9": [
+        "WebOfTrustToken(address,uint256)"
+    ],
+    "0xa5bfa9a9": [
+        "claimToken(bytes32)"
+    ],
+    "0x5669c94f": [
+        "issueToken(address,string)"
+    ],
+    "0xcdcd77c0": [
+        "baz(uint32,bool)"
+    ],
+    "0x0b811cb6": [
+        "executeProposal(uint256,bytes32)"
     ]
-};
+};

modules/db.js

@@ -1,5 +1,4 @@
 const fs = require('fs');
-const path = require('path');
 const Q = require('bluebird');
 const Loki = require('lokijs');
 const Settings = require('./settings');
@@ -10,7 +9,7 @@ let db;
 
 
 exports.init = () => {
-    const filePath = path.join(Settings.userDataPath, 'mist.lokidb');
+    const filePath = Settings.dbFilePath;
 
     return Q.try(() => {
         // if db file doesn't exist then create it

modules/settings.js

@@ -156,6 +156,11 @@ class Settings {
         return app.getPath('userData');
     }
 
+    get dbFilePath() {
+        const dbFileName = (this.inAutoTestMode) ? 'mist.test.lokidb' : 'mist.lokidb';
+        return path.join(this.userDataPath, dbFileName);
+    }
+
     get appDataPath() {
     // Application Support/
         return app.getPath('appData');

package.json

@@ -16,6 +16,8 @@
     "babel-runtime": "^6.18.0",
     "bignumber.js": "^2.1.4",
     "bluebird": "^3.3.5",
+    "chai-as-promised": "^6.0.0",
+    "chai-string": "^1.3.0",
     "electron-squirrel-startup": "^1.0.0",
     "ethereum-client-binaries": "^1.6.1",
     "ethereumjs-abi": "^0.6.3",
@@ -38,6 +40,7 @@
   },
   "devDependencies": {
     "chai": "^3.5.0",
+    "chai-as-promised": "^6.0.0",
     "co-mocha": "^1.1.2",
     "del": "^1.2.1",
     "electron": "1.3.13",
@@ -49,13 +52,15 @@
     "geth-private": "^1.3.0",
     "gulp": "^3.9.0",
     "gulp-flatten": "^0.3.0",
-    "gulp-spawn-mocha": "^2.2.2",
+    "gulp-spawn-mocha": "^3.1.0",
+    "istanbul": "^0.4.5",
     "merge-stream": "^1.0.0",
     "minimist": "^1.2.0",
+    "mocha": "^3.2.0",
     "optimist": "^0.6.1",
     "run-sequence": "^1.2.1",
     "shelljs": "^0.7.0",
-    "spectron": "^3.2.2",
+    "spectron": "3.3.0",
     "sync-request": "^3.0.1"
   }
 }

tests/_base.js

@@ -12,8 +12,9 @@ const path = require('path');
 const packageJson = require('../package.json');
 const gethPrivate = require('geth-private');
 const Application = require('spectron').Application;
-
 const chai = require('chai');
+// const ClientBinaryManager = require('../modules/clientBinaryManager');
+
 chai.should();
 
 process.env.TEST_MODE = 'true';
@@ -36,12 +37,13 @@ exports.mocha = function (_module, options) {
             const logFilePath = path.join(__dirname, 'mist.log');
             shell.rm('-rf', logFilePath);
 
-            const appFileName = (options.app === 'wallet') ? 'Ethereum Wallet' : 'Mist',
-                appVers = packageJson.version.replace(/\./ig, '-'),
-                platformArch = `${process.platform}-${process.arch}`;
+            const appFileName = (options.app === 'wallet') ? 'Ethereum Wallet' : 'Mist';
+            const appVers = packageJson.version.replace(/\./ig, '-');
+            const platformArch = `${process.platform}-${process.arch}`;
 
-            let appPath,
-                gethPath;
+            // Temporary. needs integration with ClientBinaryManager
+            const gethPath = '/Users/ev/Library/Application Support/Mist/binaries/Geth/unpacked/geth';
+            let appPath;
 
             switch (platformArch) {
             case 'darwin-x64':
@@ -68,13 +70,18 @@ exports.mocha = function (_module, options) {
                 throw new Error(`Cannot run tests on ${platformArch}, please run on: darwin-x64, linux-x64`);
             }
 
-      // check that appPath exists
+            // check that appPath exists
             if (!shell.test('-f', appPath)) {
                 throw new Error(`Cannot find binary: ${appPath}`);
             }
 
+            // const clientBinaryManager = ClientBinaryManager.init();
+            // console.log(clientBinaryManager);
+
+
             this.geth = gethPrivate({
-                gethPath: path.join(process.cwd(), 'nodes', 'geth', platformArch, 'geth'),
+                gethPath,
+                // gethPath: path.join(process.cwd(), 'nodes', 'geth', platformArch, 'geth'),
                 balance: 5,
                 genesisBlock: {
                     difficulty: '0x1',
@@ -85,49 +92,73 @@ exports.mocha = function (_module, options) {
                     rpcport: 58545,
                 },
             });
-
+            console.log(this.geth);
             yield this.geth.start();
 
             this.web3 = new Web3(new Web3.providers.HttpProvider('http://localhost:58545'));
-
-
             this.app = new Application({
                 requireName: 'electronRequire',
-                startTimeout: 5000,
-                waitTimeout: 5000,
-                quitTimeout: 10000,
+                startTimeout: 10000,
+                waitTimeout: 10000,
+                quitTimeout: 3000,
                 path: appPath,
                 args: [
                     '--mode', options.app,
                     '--loglevel', 'debug',
                     '--logfile', logFilePath,
                     '--node-datadir', this.geth.dataDir,
-                    '--ipcpath', path.join(this.geth.dataDir, 'geth.ipc'),
+                    '--rpc', path.join(this.geth.dataDir, 'geth.ipc'),
                 ],
             });
 
+            console.log('==== App info', this.app);
+
             yield this.app.start();
 
             this.client = this.app.client;
 
             yield this.client.waitUntilWindowLoaded();
 
-      // wait a small amount of time to ensure main app window is ready with data
-            yield Q.delay(8000);
+            // console.log(this.app.chromeDriver.logLines);
 
-      // console.log(this.app.chromeDriver.logLines);
-
-      /*
-      Utility methods
-       */
+            /*
+                Utility methods
+            */
             for (const key in Utils) {
                 this[key] = genomatic.bind(Utils[key], this);
             }
 
+            // Loop over windows trying to select Main Window
+            let app = this;
+            let selectMainWindow = function* (mainWindowSearch) {
+                let windowHandles = (yield app.client.windowHandles()).value;
+
+                for (let handle in windowHandles) {
+                    yield app.client.window(windowHandles[handle]);
+                    const windowUrl = yield app.client.getUrl();
+                    const isMainWindow = mainWindowSearch.test(windowUrl);
+                    if (isMainWindow) return true;
+                }
+
+                // not main window. try again after 1 second.
+                yield Q.delay(1000);
+                yield selectMainWindow(mainWindowSearch);
+            }
+
+            const mainWindowSearch = (options.app === 'wallet') ? /^file:\/\/\/$/ : /interface\/index\.html$/;
+            yield selectMainWindow(mainWindowSearch);
+
             this.mainWindowHandle = (yield this.client.windowHandle()).value;
         },
 
-        * after() {
+        * beforeEach () {
+            yield this.app.client.window(this.mainWindowHandle);
+        },
+
+        * afterEach () {
+        },
+
+        * after () {
             if (this.app && this.app.isRunning()) {
                 yield this.app.stop();
             }
@@ -214,7 +245,7 @@ const Utils = {
     );
 
         accounts = accounts.map(a => a.toLowerCase());
-        balances = balances.map(b => parseInt(b));
+        balances = balances.map(b => parseInt(b, 10));
 
         return _.object(accounts, balances);
     },
@@ -224,7 +255,7 @@ const Utils = {
         let _balances = yield this.execElemsMethod('elementIdText', '.wallet-box .account-balance');
 
         _accounts = _accounts.map(a => a.toLowerCase());
-        _balances = _balances.map(b => parseInt(b));
+        _balances = _balances.map(b => parseInt(b, 10));
 
         return _.object(_accounts, _balances);
     },
@@ -233,10 +264,10 @@ const Utils = {
 
         let idx = -1;
 
-        accId = accId.toLowerCase();
+        const accountId = accId.toLowerCase();
 
         for (const i in _accounts) {
-            if (_accounts[i].toLowerCase() === accId) {
+            if (_accounts[i].toLowerCase() === accountId) {
                 idx = i;
             }
         }