simulators/ethereum/engine: struct inputs and TransitionConfigurationV1 tests #559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcusWentz
changed the title
holiman
reviewed
Jun 2, 2022
Comment on lines
251
to
252
| // TransitionConfigurationV1 | ||
| type ExchangeTransitionConfigurationResponseExpectObject struct { |
Contributor
There was a problem hiding this comment.
This type of name is pretty common in the Java world, but in go-lang, people usually tend to use shorter names. Also, the docstring is wrong -- it should always begin with the name of the struct it is describing.
Could you please write a brief description of what this struct is/does, and then maybe we can make the name a bit briefer.
Member
Author
There was a problem hiding this comment.
Shortened name and routine docstring updated below.
holiman
reviewed
Jun 2, 2022
| } | ||
| } | ||
|
|
||
| type ExchangeTransitionConfigurationBytesResponseExpectObject struct { |
Contributor
There was a problem hiding this comment.
I don't understand the need for these types of objects.. ?
Member
Author
There was a problem hiding this comment.
The original struct was not compatible with the modified bytes version.
The original struct was not used for any tests, so I have removed the original version but kept the bytes version below.
MarcusWentz
commented
Jun 2, 2022
|
|
||
| // ExchangeTransitionConfigurationV1 in bytes format. | ||
| type ExTransConfigResponseExpectObject struct { | ||
| *TestEnv |
Member
Author
There was a problem hiding this comment.
Docstring corrected and routine name abbreviated.
Rewriting types as bytes in this context allows test size inputs beyond the original struct data types.
Member
Author
|
Closing PR since Geth patch added for logsBloom ethereum/go-ethereum#24946 |
racytech
pushed a commit
to racytech/hive
that referenced
this pull request
Apr 4, 2025
racytech
pushed a commit
to racytech/hive
that referenced
this pull request
Apr 4, 2025
🤖 I have created a release *beep* *boop* --- ## [2.2.0](ethpandaops/ethereum-package@2.1.0...2.2.0) (2024-04-19) ### Features * add assertoor test for per PR CI job ([ethereum#537](ethpandaops/ethereum-package#537)) ([8ef5c57](ethpandaops/ethereum-package@8ef5c57)) * add blutgang rpc load balancer ([ethereum#569](ethpandaops/ethereum-package#569)) ([1be5f95](ethpandaops/ethereum-package@1be5f95)) * add dugtrio beacon load balancer ([ethereum#568](ethpandaops/ethereum-package#568)) ([56d2fa3](ethpandaops/ethereum-package@56d2fa3)) * add new assertoor test to per ci jobs ([ethereum#545](ethpandaops/ethereum-package#545)) ([3005d46](ethpandaops/ethereum-package@3005d46)) * use new rpc snooper from `ethpandaops/rpc-snooper` ([ethereum#567](ethpandaops/ethereum-package#567)) ([5676f0d](ethpandaops/ethereum-package@5676f0d)) ### Bug Fixes * add --contract-deployment-block parameter for Prysm ([ethereum#557](ethpandaops/ethereum-package#557)) ([d8dfbae](ethpandaops/ethereum-package@d8dfbae)) * Added '--enable-private-discovery' to Grandine ([ethereum#541](ethpandaops/ethereum-package#541)) ([a1ae708](ethpandaops/ethereum-package@a1ae708)) * beaconchain explorer ([ethereum#531](ethpandaops/ethereum-package#531)) ([b62ed6f](ethpandaops/ethereum-package@b62ed6f)) * beaconchain explorer ([ethereum#538](ethpandaops/ethereum-package#538)) ([ce1f337](ethpandaops/ethereum-package@ce1f337)) * blobber incorrect url ([ethereum#528](ethpandaops/ethereum-package#528)) ([6f84e3d](ethpandaops/ethereum-package@6f84e3d)) * bump json rpc snooper ([ethereum#553](ethpandaops/ethereum-package#553)) ([f69c4a7](ethpandaops/ethereum-package@f69c4a7)) * disable full sync if gcmode is archive ([ethereum#563](ethpandaops/ethereum-package#563)) ([b7592ec](ethpandaops/ethereum-package@b7592ec)) * disable pbss when gcmode archive set ([ethereum#559](ethpandaops/ethereum-package#559)) ([e085462](ethpandaops/ethereum-package@e085462)) * disable pbss when gcmode archive set, force hash based init ([ethereum#562](ethpandaops/ethereum-package#562)) ([3e1c7a6](ethpandaops/ethereum-package@3e1c7a6)) * disable static peers ([ethereum#529](ethpandaops/ethereum-package#529)) ([c5d4028](ethpandaops/ethereum-package@c5d4028)) * enable single node mode on lodestar by default ([ethereum#558](ethpandaops/ethereum-package#558)) ([555ad7d](ethpandaops/ethereum-package@555ad7d)) * fix doc string typo ([ethereum#560](ethpandaops/ethereum-package#560)) ([13de3f6](ethpandaops/ethereum-package@13de3f6)) * fix failing persistence test ([ethereum#554](ethpandaops/ethereum-package#554)) ([99242d6](ethpandaops/ethereum-package@99242d6)) * increase mem limit of snooper ([ethereum#546](ethpandaops/ethereum-package#546)) ([6ba5770](ethpandaops/ethereum-package@6ba5770)) * prysm beacon http url ([ethereum#536](ethpandaops/ethereum-package#536)) ([4914531](ethpandaops/ethereum-package@4914531)) * prysm beacon_http_url ([ethereum#535](ethpandaops/ethereum-package#535)) ([ee7528c](ethpandaops/ethereum-package@ee7528c)) * prysm vc ([ethereum#533](ethpandaops/ethereum-package#533)) ([72ddeb2](ethpandaops/ethereum-package@72ddeb2)) * remove un-needed prysm vc check ([ethereum#542](ethpandaops/ethereum-package#542)) ([f6326fe](ethpandaops/ethereum-package@f6326fe)) * set application protocol to be http for rpc ([ethereum#548](ethpandaops/ethereum-package#548)) ([905de7c](ethpandaops/ethereum-package@905de7c)) * set the correct default vc image ([ethereum#544](ethpandaops/ethereum-package#544)) ([953741d](ethpandaops/ethereum-package@953741d)) * uniformize keymanager ([ethereum#534](ethpandaops/ethereum-package#534)) ([a6a2830](ethpandaops/ethereum-package@a6a2830)) * update prometheus api ([ethereum#539](ethpandaops/ethereum-package#539)) ([d2b9fb8](ethpandaops/ethereum-package@d2b9fb8)) * update vc <> cl matrix ([ethereum#564](ethpandaops/ethereum-package#564)) ([0ffcf74](ethpandaops/ethereum-package@0ffcf74)) * update vc compatibility matrix ([ethereum#543](ethpandaops/ethereum-package#543)) ([58c4684](ethpandaops/ethereum-package@58c4684)) * use `minimal-preset` images for dora & assertoor when minimal preset is used ([ethereum#532](ethpandaops/ethereum-package#532)) ([ad7773e](ethpandaops/ethereum-package@ad7773e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing inputs for Engine API struct parameters (including TransitionConfigurationV1):
-prefix (0x00)
-long
-short
TransitionConfigurationV1 tests check to see if CL == EL for parameters:
-TTD
-TerminalBlockNumber
-TerminalBlockHash
Note: cannot directly test Uint64/BigInt parameters due to marshaling restriction.
Could possibly be tested with building raw packets/RLP but also should be covered by Engine API Fuzz tests.