simulators/ethereum/engine: Trim rpc logs only at low log levels #1066
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spencer-tb
force-pushed
the
simulators/ethereum/engine/helper
branch
from
1a8e721 to
c08b4bb
Compare
spencer-tb
force-pushed
the
simulators/ethereum/engine/helper
branch
2 times, most recently
from
7fa333e to
a3cf89d
Compare
|
@marioevz - fixed the conflicts! Whispers: "merge me please"! |
spencer-tb
force-pushed
the
simulators/ethereum/engine/helper
branch
from
a3cf89d to
5ddcc3a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Forces RPC log trimming to only take affect when
--sim.loglevel <= 3. I.e to get the full log we run with:--sim.loglevel 4or--sim.loglevel 5.Related Issues or PRs
This PR can be regarded as an extension to following: #928
cc'ing @flcl42