Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn user on zero address use #676

Closed
wants to merge 3 commits into from
Closed

Warn user on zero address use #676

wants to merge 3 commits into from

Conversation

msooseth
Copy link
Collaborator

@msooseth msooseth commented Mar 4, 2025

Description

This attempts to fix #671 Still needs work, because that test in particular doesn't fire. We need to add a verbosity flag, otherwise libraries that use us will have all sorts of junk printed on the console. Default is zero (is it's seamless for libraries), but we set it to 1 in all our use-cases (cli/testing) for the moment.

Checklist

  • tested locally
  • added automated tests
  • updated the docs
  • updated the changelog

Fixing up tests, strings
@msooseth msooseth force-pushed the warn-user-zero-addr branch from f87703e to 6347e57 Compare March 5, 2025 13:10
@msooseth msooseth force-pushed the warn-user-zero-addr branch from 2e67b4b to 17ee628 Compare March 11, 2025 17:03
@msooseth msooseth changed the title [DRAFT] Warn user on zero address use Warn user on zero address use Mar 11, 2025
@msooseth msooseth marked this pull request as ready for review March 11, 2025 17:03
@msooseth msooseth requested a review from blishko March 11, 2025 17:03
Copy link
Collaborator

@blishko blishko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@@ -46,6 +46,7 @@ data Config = Config
, maxBranch :: Int
, promiseNoReent :: Bool
, maxBufSize :: Int
, verb :: Int
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be aligned with the other options? Also maxBranch seems like it is standing out.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OOops, yes, let me fix.

@msooseth
Copy link
Collaborator Author

@blishko Oh wow, I just realized I went down the wrong path here -- there was already a verbose flag. Let me try to do that instead. I'm closing this and re-opening a new one.

@msooseth msooseth closed this Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maybe emit warning when trying to call contract at address zero
2 participants