Warn user on zero address use #676
Closed
+102
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing up tests, strings
msooseth
force-pushed
the
warn-user-zero-addr
branch
from
f87703e to
6347e57
Compare
msooseth
force-pushed
the
warn-user-zero-addr
branch
from
2e67b4b to
17ee628
Compare
msooseth
changed the title
blishko
approved these changes
Mar 17, 2025
| @@ -46,6 +46,7 @@ data Config = Config | |||
| , maxBranch :: Int | |||
| , promiseNoReent :: Bool | |||
| , maxBufSize :: Int | |||
| , verb :: Int | |||
There was a problem hiding this comment.
Should this be aligned with the other options? Also maxBranch seems like it is standing out.
There was a problem hiding this comment.
OOops, yes, let me fix.
|
@blishko Oh wow, I just realized I went down the wrong path here -- there was already a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This attempts to fix #671 Still needs work, because that test in particular doesn't fire. We need to add a verbosity flag, otherwise libraries that use us will have all sorts of junk printed on the console. Default is zero (is it's seamless for libraries), but we set it to 1 in all our use-cases (cli/testing) for the moment.
Checklist