More symbolic overapproximation when the remote contract cannot be fetched, adding CodeHash SMT representation #673
+153
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msooseth
changed the title
msooseth
force-pushed
the
more-symbolic
branch
2 times, most recently
from
f791dcd to
dfcaa41
Compare
msooseth
changed the title
msooseth
force-pushed
the
more-symbolic
branch
3 times, most recently
from
65e277b to
21268bd
Compare
4 tasks
Fixing changelog Better debug Fixing build Fixing build Fixing
msooseth
changed the title
blishko
approved these changes
Mar 6, 2025
|
@blishko thanks for the review! @ggrieco-tob has kindly reviewed the EVM part of it, and it seems sane to him, so I'm merging :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This allows us to overapproximate when the contract is real, but cannot be fetched. Meant to be on top of #658 i.e.
symbolic-extcodesize. It allows us to overapproximate also when the contract cannot be fetched with RPC for opcodes:I also added
CodeHashSMT representation so concrete addresses that cannot be fetched can be abstracted away and e.g. equivalence-checked. Tests have been added that exercise this very functionality.See opcodes for reference:
Debug code has also been added to show when the system is trying to fetch data via RPC. This helps in e.g. debugging. We probably at one point want to collect this data, which would allow us to fully and correctly replay things in tests. But that's a bit far away...
Checklist