Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: fix --initial-storage option for hevm symbolic #509

Merged
merged 1 commit into from
Jul 23, 2024
Merged

cli: fix --initial-storage option for hevm symbolic #509

merged 1 commit into from
Jul 23, 2024

Conversation

d-xo
Copy link
Collaborator

@d-xo d-xo commented Jul 22, 2024

Description

We weren't respect the initial-storage option when creating the initial contract in symVmFromCommand

Checklist

  • tested locally
  • added automated tests
  • updated the docs
  • updated the changelog

@d-xo d-xo requested a review from msooseth July 22, 2024 13:09
msooseth
msooseth approved these changes Jul 23, 2024
View reviewed changes
Copy link
Collaborator

@msooseth msooseth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

But we should make sure symbolic works. I have a suspicion it may be broken.

@msooseth
Copy link
Collaborator

I just hand-tested this. Would be nice to have a test actually! But merging :)

@msooseth msooseth merged commit 3f5b21e into main Jul 23, 2024
8 checks passed
@msooseth msooseth mentioned this pull request Aug 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msooseth msooseth msooseth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@d-xo @msooseth