Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core/blockchain: Change iterator in procFutureBlocks #3655

Merged
merged 1 commit into from
Feb 18, 2017

Conversation

holiman
Copy link
Contributor

@holiman holiman commented Feb 7, 2017

to use lru.Peek instead of Get

See Get versus
Peek :

Returns the key value (or undefined if not found) without updating the "recently used"-ness of the key.

Without this change, we're reordering the recentness stochastically when processing future blocks.

@mention-bot
Copy link

@holiman, thanks for your PR! By analyzing the history of the files in this pull request, we identified @fjl, @obscuren and @karalabe to be potential reviewers.

@obscuren obscuren merged commit b19e588 into ethereum:master Feb 18, 2017
@obscuren obscuren added this to the 1.6.0 milestone Feb 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants