core/rawdb, triedb/pathdb: re-structure the trienode history header #32907
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmk142789
approved these changes
Oct 14, 2025
| keyLimit := len(keySection) | ||
| if i != len(owners)-1 { | ||
| keyLimit = int(keyOffsets[i+1]) | ||
| var keyStart, keyLimit uint32 |
Member
There was a problem hiding this comment.
We don't expect the keyStarts and Limits to exceed 2 million, right?
Member
Author
There was a problem hiding this comment.
Yes.
The dirty trienodes caused by a single block should be limited by the GasLimit.
For node key, it's the node path;
For node val, it's the mix of "full node value", and "partial node value diff";
Uint32 should be sufficient for them, unless we raise the gasLimit dramatically.
Member
Author
|
Let's merge it, making it easier for rebase work. |
rjl493456442
added a commit
to rjl493456442/go-ethereum
that referenced
this pull request
Oct 28, 2025
…thereum#32907) In this PR, several changes have been made: (a) restructure the trienode history header section Previously, the offsets of the key and value sections were recorded before encoding data into these sections. As a result, these offsets referred to the start position of each chunk rather than the end position. This caused an issue where the end position of the last chunk was unknown, making it incompatible with the freezer partial-read APIs. With this update, all offsets now refer to the end position, and the start position of the first chunk is always 0. (b) Enable partial freezer read for trienode data retrieval The partial freezer read feature is now utilized in trienode data retrieval, improving efficiency.
This was referenced Nov 3, 2025
atkinsonholly
pushed a commit
to atkinsonholly/ephemery-geth
that referenced
this pull request
Nov 24, 2025
…thereum#32907) In this PR, several changes have been made: (a) restructure the trienode history header section Previously, the offsets of the key and value sections were recorded before encoding data into these sections. As a result, these offsets referred to the start position of each chunk rather than the end position. This caused an issue where the end position of the last chunk was unknown, making it incompatible with the freezer partial-read APIs. With this update, all offsets now refer to the end position, and the start position of the first chunk is always 0. (b) Enable partial freezer read for trienode data retrieval The partial freezer read feature is now utilized in trienode data retrieval, improving efficiency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, several changes have been made:
(a) restructure the trienode history header section
Previously, the offsets of the key and value sections were recorded before encoding
data into these sections. As a result, these offsets referred to the start position of
each chunk rather than the end position.
This caused an issue where the end position of the last chunk was unknown, making
it incompatible with the freezer partial-read APIs. With this update, all offsets now
refer to the end position, and the start position of the first chunk is always 0.
(b) Enable partial freezer read for trienode data retrieval
The partial freezer read feature is now utilized in trienode data retrieval, improving
efficiency.