ethclient: add SubscribeTransactionReceipts #32869
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s1na
reviewed
Oct 9, 2025
| // TransactionReceiptsQuery defines criteria for transaction receipts subscription. | ||
| // If TransactionHashes is empty, receipts for all transactions included in new blocks will be delivered. | ||
| // Otherwise, only receipts for the specified transactions will be delivered. | ||
| type TransactionReceiptsQuery struct { |
There was a problem hiding this comment.
We can duplicate this type in ethclient. Feels weird to have a struct in the interfaces file!
There was a problem hiding this comment.
I see there are other structs in this file, for example, FilterQuery/CallMsg. How should I make the change more appropriately?
There was a problem hiding this comment.
Fair enough, forgot we have the query types also here.
s1na
changed the title
Sahil-4555
pushed a commit
to Sahil-4555/go-ethereum
that referenced
this pull request
Oct 12, 2025
Add `SubscribeTransactionReceipts` for ethclient. This is a complement to ethereum#32697.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
SubscribeTransactionReceiptsfor ethclient. This is a complement to #32697.