p2p/discover: fix timeout on refresh if no bootnodes #32515
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we have no nodes to add in a refresh, and the table is empty, it is useless to do lookups. This was triggering a 3 second wait for a timeout in the initialization code, making some hive tests fail. Signed-off-by: Csaba Kiraly <csaba.kiraly@gmail.com>
|
Note that there are a few more places we could have avoided this timeout. I've added the fix at this point, as making the lookup is useless, and it fixes the issue in itself. We can also check and fix:
|
Cassieminkus1
approved these changes
Sep 8, 2025
Cassieminkus1
approved these changes
Sep 8, 2025
|
This is also fixed by #32518 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we have no nodes to add in a refresh, and the table is empty, it is useless to do lookups.
This was triggering a 3 second wait for a timeout in the initialization code in some synthetic tests when no bootnodes were added, making some hive tests fail.
This fixes ethereum/hive#1335