fix(p2p): ensure Caps() returns a copy #32351
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I think this change is not needed. Caps has a total of two callsites within go-ethereum, and one of them is for logging. |
cuiweixie
added a commit
to cuiweixie/go-ethereum
that referenced
this pull request
Aug 12, 2025
lightclient
pushed a commit
that referenced
this pull request
Aug 21, 2025
as metioned in #32351, I think this comment is unnecessary.
gballet
pushed a commit
to gballet/go-ethereum
that referenced
this pull request
Sep 11, 2025
as metioned in ethereum#32351, I think this comment is unnecessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Peer.Caps()now returns a copy of the internal slice to prevent callers from mutating it.TestCapsReturnsCopyto verify this behavior.Why
This closes the outstanding TODO in
p2p/peer.goand ensures that external code cannot accidentally change a peer’s advertised capabilities.Checklist
go fmtandgo vetpassp2ptests (including the new one) pass