core/vm: introduce a tracer wrapper #32273
Open
+289
−150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
you mean setting the |
omerfirmak
force-pushed
the
compile-time-tracer-switch
branch
from
340fd66 to
4297593
Compare
Yeap, I was meaning that. But I replaced that with a different approach that uses generics now. |
|
In order to measure the impact of this change in a real-world benchmark, we need to introduce the |
Of course, I will follow up with that. But note that I don't see this solely as a performance optimization but something that I hope will make further optimizations (like #32160) possible with less friction. |
omerfirmak
force-pushed
the
compile-time-tracer-switch
branch
from
4297593 to
5fac41e
Compare
|
Tested with this diff diff --git a/core/vm/interpreter.go b/core/vm/interpreter.go
index 70ad4470d..e6d9eb156 100644
--- a/core/vm/interpreter.go
+++ b/core/vm/interpreter.go
@@ -202,7 +202,7 @@ func (in *EVMInterpreter) Run(contract *Contract, input []byte, readOnly bool) (
gasCopy uint64 // for EVMLogger to log gas remaining before execution
logged bool // deferred EVMLogger should ignore already logged steps
res []byte // result of the opcode execution function
- debug = in.evm.Config.Tracer != nil
+ debug = in.evm.Config.Tracer != nil && tracingEnabled[TracingDisabled]()
)
// Don't move this deferred function, it's placed before the OnOpcode-deferred method,
// so that it gets executed _after_: the OnOpcode needs the stacks before |
to clean up the callsites a little and allow compile time disabling of tracing.
omerfirmak
force-pushed
the
compile-time-tracer-switch
branch
from
5fac41e to
f6643b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to clean up the callsites a little and allow compile time disabling of tracing. The generic can be bubbled up to the
vm.EVMandvm.EVMInterpreterto allow traced and not-traced versions of them.