trie, core/state: introduce trie Prefetch for optimizing preload #32134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bench07: PR Memory allocation and CPU utilization has been reduced a lot by removing 
The overall performance is slightly faster, improved by the |
rjl493456442
changed the title
rjl493456442
force-pushed
the
trie-getbatch
branch
2 times, most recently
from
3ff33f4 to
74a1edb
Compare
rjl493456442
changed the title
rjl493456442
force-pushed
the
trie-getbatch
branch
from
74a1edb to
48bc3b3
Compare
| for _, k := range ks { | ||
| _, newnode, didResolve, err := t.get(fn.Children[pos], k, 1) | ||
| if err == nil && didResolve { | ||
| fn.Children[pos] = newnode |
There was a problem hiding this comment.
Why do we need to store the resolved node here?
There was a problem hiding this comment.
ah so we don't resolve them again on the next iteration
There was a problem hiding this comment.
We have to store the resolved nodes, otherwise the resolved descendants will be lost
|
@MariusVanDerWijden I just pushed a tiny commit on top, please check it again. |
MariusVanDerWijden
previously approved these changes
Aug 20, 2025
rjl493456442
force-pushed
the
trie-getbatch
branch
from
121d027 to
dd764fe
Compare
MariusVanDerWijden
approved these changes
Aug 20, 2025
gballet
pushed a commit
to gballet/go-ethereum
that referenced
this pull request
Sep 11, 2025
…ereum#32134) This pull introduces a `Prefetch` operation in the trie to prefetch trie nodes in parallel. It is used by the `triePrefetcher` to accelerate state loading and improve overall chain processing performance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull introduces a
Prefetchoperation in the trie to prefetch trie nodes in parallel.It is used by the
triePrefetcherto accelerate state loading and improve overallchain processing performance.