cmd/geth: add disk space cleared info to prune-history output #31930
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements issue #31916 by adding disk space information to the
prune-history
command output. The command now displays how much disk space was cleared during the pruning operation.Changes
calculateDirectorySize
helper function to measure directory sizes usingfilepath.Walk
pruneHistory
function to calculate disk usage before and after pruningcommon.StorageSize
for proper formattingcmd/geth/chaincmd_test.go
covering:Example Output
Before:
After:
Testing
Performance Considerations
filepath.Walk
for directory traversalImplementation Details
New Function:
calculateDirectorySize
Modified Function:
pruneHistory
Files Modified
cmd/geth/chaincmd.go
: Core implementationcmd/geth/chaincmd_test.go
: Comprehensive test suite (new file)Related Issues
Fixes #31916
Dones