all: rename blockchain option #31925
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjl493456442
requested review from
MariusVanDerWijden,
fjl,
s1na and
lightclient
as code owners
rjl493456442
force-pushed
the
rename-configs
branch
from
8b51fb2 to
2198d0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this pull request, the original
CacheConfighas been renamed toBlockchainOptions.Over time, more fields have been added to
CacheConfigto support blockchain configuration.Such as
ChainHistoryMode, which clearly extends beyond just caching concerns.Additionally, adding new parameters to the blockchain constructor has become increasingly
complicated, since it’s initialized across multiple places in the codebase. A natural solution
is to consolidate these arguments into a dedicated configuration struct.
As a result, the existing
CacheConfighas been redefined asBlockchainOptions. Some parameters,such as (a)
VmConfig, (b)TxLookupLimit, and (c)ChainOverrideshave been moved intoBlockchainOptionsto simplify the blockchain configuration. Besides, a few fields inBlockchainOptionsis renamed, specifically:
TrieCleanNoPrefetch->NoPrefetchTrieDirtyDisabled->ArchiveModeNotably, this change won't affect the command line flags or the toml configuration file.
It's just an internal refactoring and fully backward-compatible.