core,triedb: add fastcache metrics #31883
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jsvisa <delweng@gmail.com>
Signed-off-by: jsvisa <delweng@gmail.com>
Signed-off-by: jsvisa <delweng@gmail.com>
Signed-off-by: jsvisa <delweng@gmail.com>
| @@ -379,6 +388,20 @@ func (t *Tree) Cap(root common.Hash, layers int) error { | |||
| if !ok { | |||
| return fmt.Errorf("snapshot [%#x] is disk layer", root) | |||
| } | |||
|
|
|||
| // Update the cache stats | |||
| if diff.origin != nil && diff.origin.cache != nil { | |||
There was a problem hiding this comment.
It's very weird to upload the cache stats here.
The associated disk layer will only be modified if the size bottom-most diff layer reaches the threshold, it's not always be updated...
| if diff.origin != nil && diff.origin.cache != nil { | ||
| var stats fastcache.Stats | ||
| diff.origin.cache.UpdateStats(&stats) | ||
| snapshotCacheGetGauge.Update(int64(stats.GetCalls)) |
There was a problem hiding this comment.
I think we already have the similar metrics
snapshotCleanStorageHitMeter = metrics.NewRegisteredMeter("state/snapshot/clean/storage/hit", nil)
snapshotCleanStorageMissMeter = metrics.NewRegisteredMeter("state/snapshot/clean/storage/miss", nil)
snapshotCleanStorageInexMeter = metrics.NewRegisteredMeter("state/snapshot/clean/storage/inex", nil)
snapshotCleanStorageReadMeter = metrics.NewRegisteredMeter("state/snapshot/clean/storage/read", nil)
snapshotCleanStorageWriteMeter = metrics.NewRegisteredMeter("state/snapshot/clean/storage/write", nil)
There was a problem hiding this comment.
It's probably unnecessary to add more duplicated ones.
|
It seems a bit useless to graph the total usage of the cache, since it will always be full by definition. We do not evict items from the cache manually, so the cache will fill up and then stay at the configured limit. The more interesting metric is the hit/miss rate but we already have a metric for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add more metrics about the fastcache, so the users have a clear understanding of the use of cache and know how to configure the size of each cache.
I'm running with
This is the metrics in grafana dashboard:
I can see that the disk layer cache(
--cache.snapshot) is not used much, given 6*0.2=1.2GB, but only 30% was in use; and for the trie cache(--cache.trie) is fully used, so in my case, I now know I need to reduce the cache used for snapshot, and increase it for trie.