Skip to content

core/filtermaps: define APIs for map, epoch calculation #31659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 1, 2025

Conversation

rjl493456442
Copy link
Member

This pull request refines the filtermap implementation, defining key APIs for map and
epoch calculations to improve readability.

This pull request doesn't change any logic, it's a pure cleanup.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

@zsfelfoldi zsfelfoldi force-pushed the polish-fitermaps-2 branch from d147c1c to ea7037c Compare July 1, 2025 14:20
Copy link
Contributor

@zsfelfoldi zsfelfoldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the assertions of bitLength back in the accessor functions. It's a good change that sanitize catches invalid parameters earlier and in a nicer way but it's not good if one function assumes something about a parameter that is checked in an entirely different place and just fails silently if that assumption is not true any more for some reason (the parameter comes from elsewhere or sanitizing is not called or whatever).
Also I changed back the rowIndex vs mapRowIndex terminology. You renamed mapRowIndex to rowIndex and rowIndex to row, which is not good because mapRowIndex is not a row index, it is the combined storage position index derived from a map index and a row index. Maybe we could come up with a better name for it but that name should not be rowIndex.
Otherwise LGTM.

@zsfelfoldi zsfelfoldi merged commit cbd6ed9 into ethereum:master Jul 1, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants