Skip to content

Conversation

protolambda
Copy link
Contributor

Simple bugfix to include the access-list in the gas-estimation step of the ABI bindings code.

With OP-Stack we stumbled on it during testing of a contract that reverts when access-list data is missing.
We fixed it in op-geth here: ethereum-optimism/op-geth#546

Copy link
Member

@MariusVanDerWijden MariusVanDerWijden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@fjl
Copy link
Contributor

fjl commented Mar 15, 2025

We need to apply this on top of #31379 when it's merged.

jwasinger
jwasinger previously approved these changes Mar 15, 2025
@s1na
Copy link
Contributor

s1na commented Mar 17, 2025

#31379 is now merged. Please rebase.

@jwasinger jwasinger dismissed stale reviews from MariusVanDerWijden and themself via 3080782 March 25, 2025 17:26
Copy link
Contributor

@s1na s1na left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@s1na s1na merged commit a82303f into ethereum:master Mar 26, 2025
3 of 4 checks passed
@s1na s1na added this to the 1.15.7 milestone Mar 26, 2025
sivaratrisrinivas pushed a commit to sivaratrisrinivas/go-ethereum that referenced this pull request Apr 21, 2025
Simple bugfix to include the access-list in the gas-estimation step of
the ABI bindings code.
sduchesneau pushed a commit to streamingfast/go-ethereum that referenced this pull request May 22, 2025
Simple bugfix to include the access-list in the gas-estimation step of
the ABI bindings code.
jakub-freebit pushed a commit to fblch/go-ethereum that referenced this pull request Jul 3, 2025
Simple bugfix to include the access-list in the gas-estimation step of
the ABI bindings code.
howjmay pushed a commit to iotaledger/go-ethereum that referenced this pull request Aug 27, 2025
Simple bugfix to include the access-list in the gas-estimation step of
the ABI bindings code.
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Sep 2, 2025
Simple bugfix to include the access-list in the gas-estimation step of
the ABI bindings code.
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Sep 3, 2025
Simple bugfix to include the access-list in the gas-estimation step of
the ABI bindings code.
gzliudan added a commit to XinFinOrg/XDPoSChain that referenced this pull request Sep 8, 2025
…1417)

Simple bugfix to include the access-list in the gas-estimation step of
the ABI bindings code.

Co-authored-by: protolambda <proto@protolambda.com>
gballet pushed a commit to gballet/go-ethereum that referenced this pull request Sep 11, 2025
Simple bugfix to include the access-list in the gas-estimation step of
the ABI bindings code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants