core/types, internal/ethapi: fixes for prague RPC encoding #30926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjl
requested review from
s1na,
lightclient,
holiman and
rjl493456442
as code owners
|
Btw something I noticed is we don't transfer the authorization list on TxArgs.ToMessage |
Should fix calls with temp delegation
|
I've pushed a change to update it. |
Ngamesee00
added a commit
to Ngamesee00/go-ethereum
that referenced
this pull request
Dec 17, 2024
…thereum#30926)" This reverts commit 06dfb42.
GrapeBaBa
pushed a commit
to optimism-java/shisui
that referenced
this pull request
Dec 23, 2024
…30926) Fixing some issues I found while regenerating RPC tests for Prague: - Authorization signature values were not encoded as hex - `requestsRoot` in block should be `requestsHash` - `authorizationList` should work for `eth_call`
geoknee
added a commit
to ethereum-optimism/optimism
that referenced
this pull request
Jan 28, 2025
This was fixed upstream ethereum/go-ethereum#30926
geoknee
added a commit
to ethereum-optimism/optimism
that referenced
this pull request
Jan 28, 2025
This was fixed upstream ethereum/go-ethereum#30926
github-merge-queue bot
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Jan 28, 2025
* add RequestsHash to op-service RPCHeader type * sources.RPCHeader.RequestsHash needs "requestsHash" json struct tag not "requestsHash" as in geth * remove comment This was fixed upstream ethereum/go-ethereum#30926 * add comment * Update op-service/sources/types.go Co-authored-by: protolambda <proto@protolambda.com> --------- Co-authored-by: protolambda <proto@protolambda.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing some issues I found while regenerating RPC tests for Prague:
requestsRootin block should berequestsHashauthorizationListshould work foreth_call