Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/geth: remove unlock commandline flag #30737

Merged
merged 9 commits into from
Nov 15, 2024
Prev Previous commit
Next Next commit
cmd/geth: remove unused + docs
  • Loading branch information
holiman committed Nov 6, 2024
commit 8e1a7d9389647f018f5dcb4cc588346bece96a13
3 changes: 1 addition & 2 deletions accounts/keystore/account_cache.go
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,7 @@ func byURL(a, b accounts.Account) int {
return a.URL.Cmp(b.URL)
}

// AmbiguousAddrError is returned when attempting to unlock
// an address for which more than one file exists.
// AmbiguousAddrError is returned when an address matches multiple files.
type AmbiguousAddrError struct {
Addr common.Address
Matches []accounts.Account
Expand Down
3 changes: 1 addition & 2 deletions cmd/geth/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -351,8 +351,7 @@ func geth(ctx *cli.Context) error {
}

// startNode boots up the system node and all registered protocols, after which
// it unlocks any requested accounts, and starts the RPC/IPC interfaces and the
// miner.
// it starts the RPC/IPC interfaces and the miner.
func startNode(ctx *cli.Context, stack *node.Node, isConsole bool) {
// Start up the node itself
utils.StartNode(ctx, stack, isConsole)
Expand Down
11 changes: 0 additions & 11 deletions cmd/utils/prompt.go
Original file line number Diff line number Diff line change
Expand Up @@ -45,14 +45,3 @@ func GetPassPhrase(text string, confirmation bool) string {
}
return password
}

// GetPassPhraseWithList retrieves the first password from the given list, or
// requests one interactively from the user, using the given prompt.
func GetPassPhraseWithList(text string, passwords []string) string {
// If a list of passwords was supplied, retrieve from them
if len(passwords) > 0 {
return passwords[0]
}
// Otherwise prompt the user for the password
return GetPassPhrase(text, true)
}