Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eth/tracers): convert OOG wrapped error to Out Of Gas parity error #30497

Merged
merged 4 commits into from
Nov 1, 2024

Conversation

jsvisa
Copy link
Contributor

@jsvisa jsvisa commented Sep 23, 2024

No description provided.

Signed-off-by: jsvisa <delweng@gmail.com>
Signed-off-by: jsvisa <delweng@gmail.com>
Signed-off-by: jsvisa <delweng@gmail.com>
@jsvisa jsvisa requested a review from s1na as a code owner September 23, 2024 13:30
Signed-off-by: jsvisa <delweng@gmail.com>
Copy link
Contributor

@s1na s1na left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think in general it is hard to strive for compatibility on error messages with other clients and it is not something we should shoot for.

However given that out of gas is pretty common and it is under consensus rules I think we can make an exception.

@s1na s1na merged commit a1093d9 into ethereum:master Nov 1, 2024
3 checks passed
@jsvisa jsvisa deleted the flatcall-oog branch November 2, 2024 01:08
GrapeBaBa pushed a commit to optimism-java/shisui that referenced this pull request Nov 2, 2024
)

Compatible error message in the flat call tracer with parity-style endpoints.

Signed-off-by: jsvisa <delweng@gmail.com>
holiman pushed a commit that referenced this pull request Nov 19, 2024
Compatible error message in the flat call tracer with parity-style endpoints.

Signed-off-by: jsvisa <delweng@gmail.com>
zfy0701 pushed a commit to sentioxyz/go-ethereum that referenced this pull request Dec 3, 2024
)

Compatible error message in the flat call tracer with parity-style endpoints.

Signed-off-by: jsvisa <delweng@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants