-
Notifications
You must be signed in to change notification settings - Fork 20.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
all: implement flat deposit requests encoding #30425
Merged
Merged
Changes from 1 commit
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
5db0c7b
all: implement flat deposit requests encoding
fjl 89a441f
core/types: fix depositRequestType
fjl 8735cf3
core/types: update deposit test
fjl a2abb4b
core/types: fix deposit request encoding
fjl b3cff4e
core/types: rename to CalcRequestsHash
fjl 57f2ad1
internal/ethapi: return requests as hex
fjl c1c8a2c
internal/ethapi: avoid copying header
fjl 54ac02b
eth/catalyst: fix withdrawals return
fjl c6ba1dc
eth/catalyst: improve test
fjl 0fc9841
core: fix test
fjl ca1ed76
core/types: rename variable
fjl e9cf625
core/types: update requests hash
fjl c87fd76
core/types: update deposit request encoding
fjl e408488
all: update deposit requests format
fjl 6690bdd
all: WIP remove requests from block body
fjl eb5aaa2
core/types: fix tests issue
fjl ff99699
internal/ethapi: remove requests
fjl 0be1fe8
eth/downloader: remove requests
fjl 11e82ef
core/types: update empty hash
fjl f9cc214
eth/catalyst: change newPayload parameter to requestsHash
fjl ded9d6b
beacon/engine: remove requestsHash in payload
fjl 168d3eb
beacon/engine,eth/catalyst: ensure RequestsHash is passed to newPaylo…
lightclient 9181bd3
core: remove deposits test
fjl 9df0a64
core/types: remove empty requests hash
fjl d250deb
core/types: update requests hash function
fjl 0310778
core: remove requests var
fjl cb08ea9
eth/catalyst: remove requests in GetPayloadBodies
fjl f27902e
core: add check for requests before prague
fjl b87d536
core/types: simplify CalcRequestsHash
fjl 2509bde
core: fix deposit requests in GenerateChain
fjl 92dc664
eth/catalyst: change back to passing requests
fjl b67f40b
beacon/engine: remove RequestsHash in EPE
fjl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
core/types: update requests hash function
- Loading branch information
commit d250deb70a7aea1f7805206a6f289021a38e1692
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It can be rewrote to following to eliminate memory allocation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a very clever suggestion!