eth/protocols/eth: add protocol handler fuzzers #30417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MariusVanDerWijden
requested review from
karalabe,
holiman and
rjl493456442
as code owners
Well, the fuzzer will hit a little bit of production code, but the whole backend is a test-backend, so it's only a very small layer of handler-code that we'll fuzz. It's better than nothing, so I guess it's worth it. We might be hit with false positives if the testBackend is not quite stable, but I guess that's a passing phase. So LGTM |
Yeah that's a big hurdle for the fuzzer. Sure, with some help (seeding) it might stumble upon valid rlp once in a while, but it'll make for very inefficient fuzzing. |
Comment on lines
+511
to
+525
|
|
||
| func (d decoder) Decode(val interface{}) error { | ||
| buffer := bytes.NewBuffer(d.msg) | ||
| s := rlp.NewStream(buffer, uint64(len(d.msg))) | ||
| return s.Decode(val) | ||
| } | ||
|
|
||
| func (d decoder) Time() time.Time { | ||
| return time.Now() | ||
| } | ||
|
|
||
| func setup() (*testBackend, *testPeer) { | ||
| // Generate some transactions etc. | ||
| acc1Key, _ := crypto.HexToECDSA("8a1f9a8f95be41cd7ccb6168179afb4504aefe388d1e14474d32c45c72ce7b7a") | ||
| acc2Key, _ := crypto.HexToECDSA("49a7b37aa6f6645917e7b807e9d1c00d4fa71f18343b0d4122a4d2df64dd6fee") |
There was a problem hiding this comment.
holiman sent new code style rules
holiman
approved these changes
Sep 26, 2024
holiman
pushed a commit
that referenced
this pull request
Nov 19, 2024
Adds a protocol handler fuzzer to fuzz the ETH68 protocol handlers
zfy0701
pushed a commit
to sentioxyz/go-ethereum
that referenced
this pull request
Dec 3, 2024
Adds a protocol handler fuzzer to fuzz the ETH68 protocol handlers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a protocol handler fuzzer that will try to fuzz the protocol handlers.
Two points of discussion:
wdyt @holiman