Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitignore: ignore build signatures #30346

Merged
merged 1 commit into from
Aug 23, 2024
Merged

gitignore: ignore build signatures #30346

merged 1 commit into from
Aug 23, 2024

Conversation

holiman
Copy link
Contributor

@holiman holiman commented Aug 23, 2024

From https://app.travis-ci.com/github/ethereum/go-ethereum/jobs/625441424#L1332

$ git status --porcelain
?? geth-alltools-linux-amd64-1.14.9-unstable-0378dc83.tar.gz.asc
?? geth-alltools-linux-amd64-1.14.9-unstable-0378dc83.tar.gz.sig
?? geth-linux-amd64-1.14.9-unstable-0378dc83.tar.gz.asc
?? geth-linux-amd64-1.14.9-unstable-0378dc83.tar.gz.sig

These files are generated during signing of download-binaries, and the 'dirty' the vcs for subsequent builds.

@holiman holiman added this to the 1.14.9 milestone Aug 23, 2024
@holiman holiman merged commit 1d006bd into ethereum:master Aug 23, 2024
2 of 3 checks passed
mask-pp pushed a commit to mask-pp/go-ethereum that referenced this pull request Aug 30, 2024
@holiman @mask-pp
gitignore: ignore build signatures (ethereum#30346)
00b9e4b 
Ignore files are generated during signing of download-binaries, which 'dirty' the vcs for subsequent builds.
@BrewTestBot BrewTestBot mentioned this pull request Sep 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.14.9
Development

Successfully merging this pull request may close these issues.
1 participant
@holiman