-
Notifications
You must be signed in to change notification settings - Fork 20.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
metrics: fix TestExpDecaySampleNanosecondRegression
sometimes failed
#29832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjl493456442
approved these changes
May 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I ran the stress test locally and it can indeed capture the failure after running 2minutes.
/var/folders/sm/ytlmy_n92dnc2sxp8c5g9bhr0000gn/T/go-stress-20240524T151135-281253435
--- FAIL: TestExpDecaySampleNanosecondRegression (0.00s)
sample_test.go:144: out of range [14, 16]: 16.1
FAIL
ERROR: exit status 1
1m40s: 136 runs so far, 1 failures (0.74%)
/var/folders/sm/ytlmy_n92dnc2sxp8c5g9bhr0000gn/T/go-stress-20240524T151135-3139478043
--- FAIL: TestExpDecaySampleNanosecondRegression (0.00s)
sample_test.go:144: out of range [14, 16]: 13.9
FAIL
After switching to the new parameters, it can run without issue.
4m45s: 400 runs so far, 0 failures
4m50s: 408 runs so far, 0 failures
4m55s: 408 runs so far, 0 failures
5m0s: 416 runs so far, 0 failures
5m5s: 424 runs so far, 0 failures
5m10s: 432 runs so far, 0 failures
5m15s: 440 runs so far, 0 failures
5m20s: 448 runs so far, 0 failures
jorgemmsilva
pushed a commit
to iotaledger/go-ethereum
that referenced
this pull request
Jun 17, 2024
stwiname
pushed a commit
to subquery/data-node-go-ethereum
that referenced
this pull request
Sep 9, 2024
19 tasks
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Dec 10, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Dec 10, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Dec 10, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Dec 13, 2024
JukLee0ira
pushed a commit
to JukLee0ira/XDPoSChain
that referenced
this pull request
Dec 16, 2024
JukLee0ira
pushed a commit
to JukLee0ira/XDPoSChain
that referenced
this pull request
Dec 16, 2024
JukLee0ira
pushed a commit
to JukLee0ira/XDPoSChain
that referenced
this pull request
Dec 20, 2024
JukLee0ira
pushed a commit
to JukLee0ira/XDPoSChain
that referenced
this pull request
Dec 20, 2024
JukLee0ira
pushed a commit
to JukLee0ira/XDPoSChain
that referenced
this pull request
Dec 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestExpDecaySampleNanosecondRegression will fail sometimes
Found this issue in ci job
It hasn't always failed, I ran it on my local machine, and it's mostly been passed.
The problem is the test case using 100 as sample
reservoirSize
, which is a bit small.
reservoirSize
and run the test 1000 times, it will most likely be failed.reservoirSize
and run the test 10000 times, it will most likely be successful, I haven't failed at least