Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/ethapi: recap higher args.Gas with block GasLimit in DoEstimateGas #29738

Merged
merged 5 commits into from
Jun 4, 2024
Merged

internal/ethapi: recap higher args.Gas with block GasLimit in DoEstimateGas #29738

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
97a4b12
internal/ethapi: recap higher args.Gas with block GasLimit in DoEstim…
SangIlMo May 8, 2024
8465891
internal/ethapi: fix gas estimator capping code
karalabe Jun 3, 2024
e7865d6
Merge branch 'master' into fix/esitmateGas_uses_global_gas_cap_#29695
karalabe Jun 3, 2024
92d1f2f
internal/ethapi: fix test
karalabe Jun 3, 2024
e2d3560
fix goimports lint (remove space)
SangIlMo Jun 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions internal/ethapi/api.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1202,6 +1202,11 @@ func DoEstimateGas(ctx context.Context, b Backend, args TransactionArgs, blockNr
if err := args.CallDefaults(gasCap, header.BaseFee, b.ChainConfig().ChainID); err != nil {
return 0, err
}
// when gas is over header.GasLimit, just recap with header.GasLimit
if uint64(*args.Gas) > header.GasLimit {
*args.Gas = (hexutil.Uint64)(header.GasLimit)
SangIlMo marked this conversation as resolved.
Show resolved Hide resolved
}

call := args.ToMessage(header.BaseFee)
// Run the gas estimation andwrap any revertals into a custom return
estimate, revert, err := gasestimator.Estimate(ctx, call, opts, gasCap)
Expand Down