Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/devp2p, eth: drop eth/66 #28239

Merged
merged 2 commits into from
Oct 3, 2023
Merged

cmd/devp2p, eth: drop eth/66 #28239

merged 2 commits into from
Oct 3, 2023

Conversation

karalabe
Copy link
Member

@karalabe karalabe commented Oct 3, 2023

Blob transactions - along with the Cancun hard fork - require eth/68. At this point is easier to start dropping old protocols than jumping through hoops making sure they don't accidentally work wonky with blob transactions.

@karalabe karalabe added this to the 1.13.3 milestone Oct 3, 2023
Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karalabe karalabe merged commit bc6d184 into ethereum:master Oct 3, 2023
2 checks passed
hyunchel pushed a commit to hyunchel/go-ethereum that referenced this pull request Oct 6, 2023
* cmd/devp2p, eth: drop eth/66

* eth/protocols/eth: yes sir, linter
tyler-smith pushed a commit to blocknative/go-ethereum that referenced this pull request Oct 12, 2023
* cmd/devp2p, eth: drop eth/66

* eth/protocols/eth: yes sir, linter
tyler-smith pushed a commit to blocknative/go-ethereum that referenced this pull request Oct 16, 2023
* cmd/devp2p, eth: drop eth/66

* eth/protocols/eth: yes sir, linter
devopsbo3 pushed a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
* cmd/devp2p, eth: drop eth/66

* eth/protocols/eth: yes sir, linter
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
0xmountaintop added a commit to scroll-tech/go-ethereum that referenced this pull request May 24, 2024
0xmountaintop added a commit to scroll-tech/go-ethereum that referenced this pull request May 28, 2024
0xmountaintop added a commit to scroll-tech/go-ethereum that referenced this pull request May 28, 2024
0xmountaintop added a commit to scroll-tech/go-ethereum that referenced this pull request Jun 24, 2024
0xmountaintop added a commit to scroll-tech/go-ethereum that referenced this pull request Jun 26, 2024
0xmountaintop added a commit to scroll-tech/go-ethereum that referenced this pull request Jul 9, 2024
0xmountaintop added a commit to scroll-tech/go-ethereum that referenced this pull request Jul 25, 2024
0xmountaintop added a commit to scroll-tech/go-ethereum that referenced this pull request Jul 27, 2024
0xmountaintop added a commit to scroll-tech/go-ethereum that referenced this pull request Jul 28, 2024
0xmountaintop added a commit to scroll-tech/go-ethereum that referenced this pull request Aug 1, 2024
0xmountaintop added a commit to scroll-tech/go-ethereum that referenced this pull request Aug 3, 2024
omerfirmak pushed a commit to scroll-tech/go-ethereum that referenced this pull request Oct 8, 2024
omerfirmak pushed a commit to scroll-tech/go-ethereum that referenced this pull request Oct 8, 2024
0xmountaintop added a commit to scroll-tech/go-ethereum that referenced this pull request Oct 15, 2024
0xmountaintop added a commit to scroll-tech/go-ethereum that referenced this pull request Oct 15, 2024
omerfirmak pushed a commit to scroll-tech/go-ethereum that referenced this pull request Oct 18, 2024
colinlyguo added a commit to scroll-tech/go-ethereum that referenced this pull request Oct 23, 2024
* Revert "cmd/devp2p, eth: drop eth/66 (ethereum#28239)"

This reverts commit bc6d184.

* hack shanghaiBlock

* disable time-based forks in ForkID

---------

Co-authored-by: colinlyguo <colinlyguo@scroll.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants