-
Notifications
You must be signed in to change notification settings - Fork 20.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/devp2p, eth: drop eth/66 #28239
Merged
Merged
cmd/devp2p, eth: drop eth/66 #28239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holiman
approved these changes
Oct 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
hyunchel
pushed a commit
to hyunchel/go-ethereum
that referenced
this pull request
Oct 6, 2023
* cmd/devp2p, eth: drop eth/66 * eth/protocols/eth: yes sir, linter
tyler-smith
pushed a commit
to blocknative/go-ethereum
that referenced
this pull request
Oct 12, 2023
* cmd/devp2p, eth: drop eth/66 * eth/protocols/eth: yes sir, linter
tyler-smith
pushed a commit
to blocknative/go-ethereum
that referenced
this pull request
Oct 16, 2023
* cmd/devp2p, eth: drop eth/66 * eth/protocols/eth: yes sir, linter
devopsbo3
pushed a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
* cmd/devp2p, eth: drop eth/66 * eth/protocols/eth: yes sir, linter
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
This reverts commit 293fc40.
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
This reverts commit 293fc40.
0xmountaintop
added a commit
to scroll-tech/go-ethereum
that referenced
this pull request
May 24, 2024
This reverts commit bc6d184.
0xmountaintop
added a commit
to scroll-tech/go-ethereum
that referenced
this pull request
May 28, 2024
This reverts commit bc6d184.
0xmountaintop
added a commit
to scroll-tech/go-ethereum
that referenced
this pull request
May 28, 2024
This reverts commit bc6d184.
0xmountaintop
added a commit
to scroll-tech/go-ethereum
that referenced
this pull request
Jun 24, 2024
This reverts commit bc6d184.
0xmountaintop
added a commit
to scroll-tech/go-ethereum
that referenced
this pull request
Jun 26, 2024
This reverts commit bc6d184.
0xmountaintop
added a commit
to scroll-tech/go-ethereum
that referenced
this pull request
Jul 9, 2024
This reverts commit bc6d184.
0xmountaintop
added a commit
to scroll-tech/go-ethereum
that referenced
this pull request
Jul 25, 2024
This reverts commit bc6d184.
0xmountaintop
added a commit
to scroll-tech/go-ethereum
that referenced
this pull request
Jul 27, 2024
This reverts commit bc6d184.
0xmountaintop
added a commit
to scroll-tech/go-ethereum
that referenced
this pull request
Jul 28, 2024
This reverts commit bc6d184.
0xmountaintop
added a commit
to scroll-tech/go-ethereum
that referenced
this pull request
Aug 1, 2024
This reverts commit bc6d184.
0xmountaintop
added a commit
to scroll-tech/go-ethereum
that referenced
this pull request
Aug 3, 2024
This reverts commit bc6d184.
omerfirmak
pushed a commit
to scroll-tech/go-ethereum
that referenced
this pull request
Oct 8, 2024
This reverts commit bc6d184.
omerfirmak
pushed a commit
to scroll-tech/go-ethereum
that referenced
this pull request
Oct 8, 2024
This reverts commit bc6d184.
0xmountaintop
added a commit
to scroll-tech/go-ethereum
that referenced
this pull request
Oct 15, 2024
This reverts commit bc6d184.
0xmountaintop
added a commit
to scroll-tech/go-ethereum
that referenced
this pull request
Oct 15, 2024
This reverts commit bc6d184.
omerfirmak
pushed a commit
to scroll-tech/go-ethereum
that referenced
this pull request
Oct 18, 2024
This reverts commit bc6d184.
colinlyguo
added a commit
to scroll-tech/go-ethereum
that referenced
this pull request
Oct 23, 2024
* Revert "cmd/devp2p, eth: drop eth/66 (ethereum#28239)" This reverts commit bc6d184. * hack shanghaiBlock * disable time-based forks in ForkID --------- Co-authored-by: colinlyguo <colinlyguo@scroll.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blob transactions - along with the Cancun hard fork - require eth/68. At this point is easier to start dropping old protocols than jumping through hoops making sure they don't accidentally work wonky with blob transactions.