Update ethclient.go #28200
Update ethclient.go #28200
Conversation
Reverting changes from v13 that broke smart contract function calls
|
CC @fjl |
|
It's worth noting that this change was flagged as potentially problematic three weeks ago, specifically in relation to its compatibility with Prysm. I am indeed using a setup that involves Erigon + Prysm, and the current "input" naming appears to be incompatible, leading to the issues with Smart Contract calls. |
|
Geth has supported both names ( |
|
Please ping the relevant projects that they are not in sync with the spec (6 years out of sync). The simplest thing to do is on server side to accept both, and gradually transition clients to input from data. We kind of allowed 6 years transition period in Geth. |
indanielo@gpuserver:/mnt/bigdata/erigon$ ./build/bin/erigon --version indanielo@gpuserver:/mnt/bigdata/prysm$ sudo ./prysm.sh validator --version indanielo@gpuserver:/mnt/bigdata/prysm$ sudo ./prysm.sh beacon-chain --version |
|
I'll try to reproduce this with erigon, seems maybe they don't fully support the naming. Since there have also been reports about issues, with other tools, we may consider to revert this renaming after all. |
Feel free to ask for any additional information you may need. If required, I can provide a code snippet to reproduce the issue. Thanks for the help! |
3 participants
Fix: Revert "input" field to "data" in
ethclient.gofor Smart Contract Calls in v13The field name change from "data" to "input" in
ethclient.goin version 13 has caused Smart Contract calls to not properly receive the data payload. This was not an issue in version 12 where the field was named "data". This commit reverts the field name back to "data" to fix Smart Contract call issues.