core/types: reimplement log.EncodeRLP

[jsvisa]

fix #28008

[fjl]

It's nice you're submitting this, but I really think it should be handled in rlpgen instead. The method is there, so it should recognize that. The only reason why it does complain, is because function type-checking is turned on in the package loader.

[jsvisa]

Or we should use rlp.Encode instead of log.EncodeRLP(revert back) in

go-ethereum/core/types/receipt.go

Lines 272 to 275 in 6aa88cc

	for _, log := range r.Logs {
	if err := log.EncodeRLP(w); err != nil {
	return err
	}

just curious, why we changed from rlp.Encode to log.EncodeRLP in #27976

[fjl]

I changed it because it's way faster to call the method directly. The reason why rlpgen fails, is because it applies the build tag norlpgen during code generation.

[jsvisa]

@fjl thanks for the information, I changed the behavior in rlpgen, please take another look, thanks.

[fjl]

I decided to just always remove the build tag for now: #28106