cmd, core, eth, params: implement flags to control dao fork blocks #2788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated: Sat Jul 16 10:10:08 UTC 2016 |
This was referenced Jul 8, 2016
|
Superseeded and merged in #2814. |
sduchesneau
pushed a commit
to streamingfast/go-ethereum
that referenced
this pull request
Feb 10, 2025
…thereum#2788) Bumps [github.com/golang-jwt/jwt/v4](https://github.com/golang-jwt/jwt) from 4.5.0 to 4.5.1. - [Release notes](https://github.com/golang-jwt/jwt/releases) - [Changelog](https://github.com/golang-jwt/jwt/blob/main/VERSION_HISTORY.md) - [Commits](golang-jwt/jwt@v4.5.0...v4.5.1) --- updated-dependencies: - dependency-name: github.com/golang-jwt/jwt/v4 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements setting the
--support-dao-forkand--oppose-dao-forkflags. As of now they only modify a single database entry specifying whether the current default behavior should change.--support-dao-forkwill set it to either mainnet/testnet number--support-dao-forkwill leave it at its present value--oppose-dao-forkwill remove itCaveat: setting the dao number from a custom genesis file, removing it via
--oppose-dao-forkand reenabling it via--support-dao-forkwill result in the mainnet/testnet number being set, the original private number being lost. Don't use this willy nilly on private networks; rather usegeth init genesis.jsonfor those scenarios.This PR further drops support to the deprecated
--genesisflag. This is important because the--support-dao-forkand--oppose-dao-forkflags need to know the previous state/number in the database to ensure it's not accidentally overwritten! We do not know this with the--genesisflag as the user might supply something we can only interpret much later in the code. Note, for main and test network we know in advance what their genesis file would contain, so that's not an issue.