Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: ensure txindex will be triggered at least once #27847

Merged
merged 7 commits into from
Aug 22, 2023
Merged

core: ensure txindex will be triggered at least once #27847

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
66ea343
core: ensure txindex will be triggered at least once
jsvisa Aug 3, 2023
685932a
core: spin a reindex task before subscribe
jsvisa Aug 4, 2023
a2e1fdd
core: cherry-pick from rj's review
jsvisa Aug 4, 2023
4273f24
core: launch indexBlock only if tail is not null
jsvisa Aug 7, 2023
60b2862
don't check tail
jsvisa Aug 17, 2023
0dda9cf
no need to indexing if head is 0
jsvisa Aug 17, 2023
71374ae
Update core/blockchain.go
holiman Aug 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion core/blockchain.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2334,7 +2334,9 @@ func (bc *BlockChain) skipBlock(err error, it *insertIterator) bool {

// indexBlocks reindexes or unindexes transactions depending on user configuration
func (bc *BlockChain) indexBlocks(tail *uint64, head uint64, done chan struct{}) {
defer func() { close(done) }()
if done != nil {
defer func() { close(done) }()
}

// The tail flag is not existent, it means the node is just initialized
// and all blocks(may from ancient store) are not indexed yet.
Expand Down Expand Up @@ -2383,6 +2385,13 @@ func (bc *BlockChain) indexBlocks(tail *uint64, head uint64, done chan struct{})
func (bc *BlockChain) maintainTxIndex() {
defer bc.wg.Done()

// Geth should always index/uninindex the unfinished chain segments,
// in case the chain has no progress for a long time.
head := rawdb.ReadHeadBlock(bc.db)
if head != nil {
bc.indexBlocks(rawdb.ReadTxIndexTail(bc.db), head.NumberU64(), nil)
}

jsvisa marked this conversation as resolved.
Show resolved Hide resolved
// Listening to chain events and manipulate the transaction indexes.
var (
done chan struct{} // Non-nil if background unindexing or reindexing routine is active.
Expand Down