Skip to content

rlp, apitypes; use slices package for sorting #27495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

rlp, apitypes; use slices package for sorting #27495

wants to merge 1 commit into from

Conversation

@danlaine
Copy link

@danlaine danlaine commented Jun 16, 2023

See #27474

@danlaine danlaine requested a review from holiman as a code owner June 16, 2023 13:52
@fjl
Copy link
Contributor

fjl commented Jun 16, 2023

Replacing sort.Strings by slices.Sort seems weird to me. It makes sense to do the replacement if it allows removing an implementation of sort.Interface. But that's not the case here.

Also, both of these places are absolutely not performance-critical.

@fjl fjl closed this Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@holiman holiman Awaiting requested review from holiman

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@danlaine @fjl