Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal,tests: replace noarg fmt.Errorf with errors.New #27335

Merged
merged 4 commits into from
May 25, 2023
Merged

internal,tests: replace noarg fmt.Errorf with errors.New #27335

merged 4 commits into from
May 25, 2023

Conversation

jsvisa
Copy link
Contributor

@jsvisa jsvisa commented May 24, 2023

similar to #27329

jsvisa added 2 commits May 24, 2023 09:58
@jsvisa
internal: replace noarg fmt.Errorf with errors.New
75e4db5 
Signed-off-by: jsvisa <delweng@gmail.com>
@jsvisa
tests: replace noarg fmt.Errorf with errors.New
9790667 
Signed-off-by: jsvisa <delweng@gmail.com>
@s1na
Copy link
Contributor

s1na commented May 24, 2023 

>>> build/cache/golangci-lint-1.51.1-linux-amd64/golangci-lint run --config .golangci.yml ./...
tests/fuzzers/trie/trie-fuzzer.go:1: : # github.com/ethereum/go-ethereum/tests/fuzzers/trie
tests/fuzzers/trie/trie-fuzzer.go:186:12: undefined: errors (typecheck)
// Copyright 2019 The go-ethereum Authors
tests/block_test_util.go:1: : # github.com/ethereum/go-ethereum/tests [github.com/ethereum/go-ethereum/tests.test]
tests/init_test.go:183:10: undefined: errors (typecheck)
// Copyright 2015 The go-ethereum Authors
util.go:48: exit status 1
exit status 1
Command exited with code 1

@jsvisa
tests: go autoimport
39151b9 
Signed-off-by: jsvisa <delweng@gmail.com>
@jsvisa
Copy link
Contributor Author

jsvisa commented May 24, 2023 •
edited
Loading

sorry, missed the go autoimport

@jsvisa
tests: go autoimport
8aace2f 
Signed-off-by: jsvisa <delweng@gmail.com>
holiman
holiman approved these changes May 25, 2023
View reviewed changes
Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holiman holiman merged commit b21ba66 into ethereum:master May 25, 2023
@holiman holiman added this to the 1.12.0 milestone May 25, 2023
devopsbo3 pushed a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
@jsvisa @devopsbo3
internal,tests: replace noarg fmt.Errorf with errors.New (ethereum#27335
7db2b71 
)

* internal: replace noarg fmt.Errorf with errors.New

Signed-off-by: jsvisa <delweng@gmail.com>

* tests: replace noarg fmt.Errorf with errors.New

Signed-off-by: jsvisa <delweng@gmail.com>

* tests: go autoimport

Signed-off-by: jsvisa <delweng@gmail.com>

* tests: go autoimport

Signed-off-by: jsvisa <delweng@gmail.com>

---------

Signed-off-by: jsvisa <delweng@gmail.com>
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
@devopsbo3
Revert "internal,tests: replace noarg fmt.Errorf with errors.New (eth…
10208ca 
…ereum#27335)"

This reverts commit 7db2b71.
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
@devopsbo3
Revert "internal,tests: replace noarg fmt.Errorf with errors.New (eth…
2ce546e 
…ereum#27335)"

This reverts commit 7db2b71.
@jsvisa jsvisa deleted the internal-errorf branch September 5, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holiman holiman holiman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jsvisa @s1na @holiman