Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eth: fix crash on querying finalized block #27162

Merged
merged 1 commit into from
Apr 25, 2023

Conversation

s1na
Copy link
Contributor

@s1na s1na commented Apr 25, 2023

Fixes #27157

Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about line 130, shouldn't we fix that too while we're at it?

Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, re my earlier comment: I guess CurrentBlock is genesis if nothing else, so should be fine

@holiman holiman added this to the 1.11.7 milestone Apr 25, 2023
@holiman holiman merged commit b1113aa into ethereum:master Apr 25, 2023
shekhirin pushed a commit to shekhirin/go-ethereum that referenced this pull request Jun 6, 2023
eth: fix crash on querying nil finalized block
devopsbo3 pushed a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
eth: fix crash on querying nil finalized block
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid memory address or nil pointer dereference error when sync starts
2 participants