Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc,internal/cmdtest: increase timeout in tests #27083

Merged
merged 3 commits into from
May 22, 2023
Merged

rpc,internal/cmdtest: increase timeout in tests #27083

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f3e1ffe
rpc: increase subscribeTimeout from 5s to 10s
jsvisa Apr 11, 2023
865fdd4
internal/cmdtest: increase kill timeout from 5s to 30s
jsvisa Apr 11, 2023
559c449
cmd/geth: kill the test in attach testing
jsvisa May 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
cmd/geth: kill the test in attach testing 
Signed-off-by: jsvisa <delweng@gmail.com>
  • Loading branch information
@jsvisa
jsvisa committed May 9, 2023
commit 559c449266506841da029cdc00ff9e80f3b58fbb
2 changes: 1 addition & 1 deletion cmd/geth/consolecmd_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ func TestAttachWelcome(t *testing.T) {
waitForEndpoint(t, endpoint, 3*time.Second)
testAttachWelcome(t, geth, endpoint, httpAPIs)
})
geth.ExpectExit()
geth.Kill()
}

func testAttachWelcome(t *testing.T, geth *testgeth, endpoint, apis string) {
Expand Down